[zeromq-dev] [PATCH] Fix incorrect include usage on Windows #2

Steven McCoy steven.mccoy at miru.hk
Wed Jun 15 23:18:29 CEST 2011


Tested correct on all 6 Windows build configurations.  The only remaining
question I have is regarding the rather silly NOxxx definitions, I updated
to SDK 7 *windows.h* but they really don't need to be there at all.

These two patches should be merged, is that possible with git without a
repo?

Patch #3 fixes MinGW which appears to define _WIN32_WINNT before
*windows.h*which most likely means throughout compilation it would
have a different
value to WINVER and hence would generate interesting results.

-- 
Steve-o
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zeromq.org/pipermail/zeromq-dev/attachments/20110615/258ac557/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Update-Windows-header-file-usage.patch
Type: application/octet-stream
Size: 5869 bytes
Desc: not available
URL: <http://lists.zeromq.org/pipermail/zeromq-dev/attachments/20110615/258ac557/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Undefine-_WIN32_WINNT-on-Mingw-alongside-WINVER.patch
Type: application/octet-stream
Size: 706 bytes
Desc: not available
URL: <http://lists.zeromq.org/pipermail/zeromq-dev/attachments/20110615/258ac557/attachment-0001.obj>


More information about the zeromq-dev mailing list